Skip to content

Fix Serial.available() example #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

diamondo25
Copy link

No description provided.

@SimonePDA
Copy link

The current Mega example is working and clearly shows the input and output process. It con be shortened as suggested, but it is less useful for the learning user. Moreover as it is not broken, the term "Fix" is not the proper one. It is a suggestion.

@diamondo25
Copy link
Author

Nope, the code does not work in the current version of Arduino, as the BYTE keyword is not supported anymore.

@SimonePDA
Copy link

As for the first example, we will change BYTE to DEC, fixing the code without altering the basic purpose of showing an input and an output on two different serial streams.

Thanks for the "BYTE" fix that wasn't clearly pointed out as the reason of the fix.
We have to go through many pull requests and sometimes without any comment given, it is very difficult for us to understand which is the reason why a pull request is made.

SimonePDA pushed a commit that referenced this pull request Mar 28, 2018
Fixes the issue with BYTE keyword that is no longer supported, fixing #320
@SimonePDA SimonePDA mentioned this pull request Mar 28, 2018
@SimonePDA SimonePDA closed this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants