Build s/ latest MSBuild / Visual Studio installed #15
Conversation
|
/to @pranavkm |
dougbu
force-pushed
the
dougbu/licenses.2
branch
from
7ded75c to
1a987f8
Compare
dougbu
force-pushed
the
dougbu/build.w.latest.12
branch
from
3c32605 to
d1cfceb
Compare
There was a problem hiding this comment.
This looks like a bug fix. Except, we've never seen this fail before - odd that a bug like this would exist because this code hasn't changed in 5+ years.
Please log a bug for this and do it in a separate PR.
There was a problem hiding this comment.
I agree it's possible the code analysis has uncovered an actual bug -- FxCop has evolved (slightly) over the years. But it would be worse to suppress the warning than to fix it at this time. Build doesn't succeed w/o this fix using latest tools.
There was a problem hiding this comment.
I'm not suggesting suppressing it... I just don't want to mix what appears to be a bug fix with some code cleanup.
|
🕐 |
- #12 - find `MSBuild.exe` and `Microsoft.Build.Tasks.*.dll` for v14.0 before v12.0 - avoid errors and warnings the latest compiler detects - fix test that now hits NRE; unclear how it ever ran successfully nits: - add solution for tools - ignore .vs directory
- suppress MW1201 FxCop rule for `UriExtensions.TryReadQueryAs()` to avoid #16
dougbu
force-pushed
the
dougbu/build.w.latest.12
branch
from
d1cfceb to
062ad7d
Compare
|
🆙📅 This PR no longer addresses #17 nor the consistent |
| /// <param name="value">An object to be initialized with this instance or null if the conversion cannot be performed.</param> | ||
| /// <returns><c>true</c> if the query component can be read as the specified type; otherwise <c>false</c>.</returns> | ||
| [SuppressMessage("Microsoft.Design", "CA1007:UseGenericsWhereAppropriate", Justification = "This is the non-generic version.")] | ||
| [SuppressMessage("Microsoft.Web.FxCop", "MW1201", Justification = "Avoid an NRE in our custom rule (see AspNetWebStack#16). Occurs while handling JTokenReader.Dispose().")] |
|
|
1 similar comment
|
|
MSBuild.exeandMicrosoft.Build.Tasks.*.dllfor v14.0 before v12.0nits: