Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@rmja
Copy link
Contributor

@rmja rmja commented May 23, 2016

Resolves #89

@dnfclas
Copy link

dnfclas commented May 23, 2016

Hi @rmja, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented May 23, 2016

@rmja, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@SteveSandersonMS
Copy link
Member

Thanks very much! This is now merged.

If you discover anything not working on .NET 4.5.1, please let me know. My testing has been all about .NET Core.

@aminebizid
Copy link

Thank you
Nuget ready?

@laskoviymishka
Copy link
Contributor

What about netsyandart 1.6? It's escalate quickly :)

@xabikos
Copy link
Contributor

xabikos commented Jun 1, 2016

Actually instead of targeting netstandard1.6 we should try and target a lowest number if possible (1.3) as this would give much more compatibility especially now that full .net framework is supported. Of course I don't know if it's possible based on api's the library uses.

@laskoviymishka
Copy link
Contributor

Well it could, we need investigate possibilities of such targeting's

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants