Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@winstliu
Copy link
Contributor

Things like MY_COOL_VAR are now tokenized under constant.other.js (which could be constant.other.global.js, wasn't sure which one was best). Also be aware I'm not too familiar with JS so this PR could totally be on the wrong track.

First time I managed to get a language spec I wrote to pass 😄.

Refs #137.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runaway tabs! 🏃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blame the web editor 😉

@mehcode
Copy link

mehcode commented Apr 22, 2015

JavaScript has const x = 1; if there is a way we can mark / tag x as a constant (following scope correctly) that'd be nice. ALL_CAP variables are generally constants as well from a naming perspective so I'd be okay with this too.

kevinsawicki added a commit that referenced this pull request Apr 22, 2015
Tokenize ALL_CAPS variables
@kevinsawicki kevinsawicki merged commit 83c75dc into master Apr 22, 2015
@kevinsawicki
Copy link
Contributor

Looks good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants