refactored One Shot Mode functionality and added CANCTRL_REQOP_OSM #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a CANCTRL_REQOP_MODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings this library from version 1.2.1 to 1.3.1
It adds setNormalOneShotMode(), a form of Normal Mode in which the 2515 only sends a message once without requiring acknowledgements from another node in Normal Mode in the same bus as would be the case if all the other nodes in the bus are in ListenOnlyMode.
This PR merges the code from @DeltaC6 and the insight from @igorok107 on the correct mask to use to make it work
https://github.com/DeltaC6/arduino-mcp2515/tree/master
#65 (comment)
This code has been verified on the ArduinoEnigma CanBusTool
https://arduinoenigma.blogspot.com/2024/12/can-bus-tool.html
PR History:
Initial PR using flags and set/reset functions
#124
This PR refactored code and created a single method setNormalOneShotMode() but gave compilation errors on some platforms
#128
Compiles cleanly but all changes to library show up as different commits
#130