Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/amazon-ec2-instance-selector
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.3.1
Choose a base ref
...
head repository: aws/amazon-ec2-instance-selector
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.2
Choose a head ref
  • 7 commits
  • 6 files changed
  • 4 contributors

Commits on Jun 27, 2022

  1. Deprecated filter methods (#133)

    * fixed issue with OD pricing for european regions
    
    * made string replacement more readable in getRegionForPricingAPI
    
    * implemented sorting of instance types
    
    * fixed typo in filtering error message
    
    * moved sort to selector.go and refactored FilterVerbose tests
    
    * brought back FilterWithOutput() in selector.go
    
    * working implementation of refactoring solution
    
    * Deprecated the filter methods in selector.go
    
    * added the names of replacement functions to deprecated comments
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Jun 27, 2022
    Configuration menu
    Copy the full SHA
    8ac398b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Refactoring of Filter functions (#134)

    * fixed issue with OD pricing for european regions
    
    * made string replacement more readable in getRegionForPricingAPI
    
    * implemented sorting of instance types
    
    * fixed typo in filtering error message
    
    * moved sort to selector.go and refactored FilterVerbose tests
    
    * brought back FilterWithOutput() in selector.go
    
    * working implementation of refactoring solution
    
    * added method comments
    
    * converted Filter and FilterVerbose tests to TestGetFilteredOutput tests
    
    * added filtering and output tests
    
    * split filter functions into fetching filtered types and outputing types
    
    * removed OutputInstanceTypes. Output functions only in Outputs.go
    
    * fixed typos and updated function comments
    
    * fixed invalid maxResults check in main
    
    * added error to TruncateResults for negative values
    
    * updated error message for formatting instance types
    
    * reduced the amount of times pricing caches are refreshed
    
    * fixed cache refresh related comments
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Jul 6, 2022
    Configuration menu
    Copy the full SHA
    fd78895 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. updated readme (#136)

    * updated example code in readme
    
    * updated help printout in readme
    
    * added simple output to choices for output format
    
    * added a drop down for v2.3.1 example code
    
    * fixed v2.3.1 example code
    
    * copied v2.3.1 example code from old readme
    
    Co-authored-by: Rodrigo Okamoto <[email protected]>
    digocorbellini and Rodrigo Okamoto authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    8d513bc View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Revert "updated readme" and "Refactoring of Filter functions" (#139)

    * Revert "updated readme (#136)"
    
    This reverts commit 8d513bc.
    
    * Revert "Refactoring of Filter functions (#134)"
    
    This reverts commit fd78895.
    AustinSiu authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    338d9e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cec208c View commit details
    Browse the repository at this point in the history
  3. Update README.md (#141)

    brycahta authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    603b2d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Configuration menu
    Copy the full SHA
    0154f4b View commit details
    Browse the repository at this point in the history
Loading