Refactoring of Filter functions #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue with OD pricing for european regions (aws#132)
main into sorting
bwagner5
reviewed
Jun 28, 2022
AustinSiu
reviewed
Jun 28, 2022
AustinSiu
reviewed
Jun 29, 2022
AustinSiu
reviewed
Jun 29, 2022
AustinSiu
reviewed
Jun 30, 2022
AustinSiu
reviewed
Jul 1, 2022
AustinSiu
approved these changes
Jul 1, 2022
bwagner5
reviewed
Jul 5, 2022
AustinSiu
added a commit
to AustinSiu/amazon-ec2-instance-selector
that referenced
this pull request
Jul 11, 2022
This reverts commit fd78895.
AustinSiu
added a commit
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The responsibilities of the
Filter(),FilterVerbose(), andFilterWithOutput()functions inselector.gohave been replaced withFilterInstanceTypes(), which fetches a filtered list of instance types details, and now if instance types must need to be outputted, the appropriate output function inoutputs.gomust be called.TruncateResultshas also been moved tooutputs.goand made public.Refreshing of pricing caches has been moved from solely occurring in main to also occurring in
FilterInstanceTypes(). This allows library users to also get OD and spot pricing information when they request filtered instance types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.