Fixed EKS testing bug #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Since the release of go 1.19, the EKS tests:
TestEKSDefaultServiceandTestEKSDefaultService_FailLatestReleaseUseFallbackStaticVersionwere failing due to the path to the testing zip fileamazon-eks-ami-20210125.zipnot being set correctly.In
eksGithubReleaseHTTPServer,w.Header().Add()was being called afterw.WriteHeader()which would mean that the header map was not being modified. The go documentation forHeader()states:"Changing the header map after a call to WriteHeader (or Write) has no effect unless the HTTP status code was of the 1xx class or the modified headers are trailers."
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.