Skip to content

Conversation

digocorbellini
Copy link
Contributor

Issue #, if available:

Description of changes:
Previously, if you resized the terminal so that its height was less than the height of the table footer and header combined, a visual bug would occur where both the header and footer would disappear and there would be two highlighted rows. This is shown in the image below:
Screen Shot 2022-08-11 at 2 58 50 PM

Now, if the terminal height is less than the height of the table footer and header combined, both the header and footer will be disabled and only 1 row will be visible. This prevents the visual bug from occurring while also leaving space for the filtering text to appear. The new format is shown below:
Screen Shot 2022-08-11 at 2 59 30 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@digocorbellini digocorbellini requested a review from a team as a code owner August 11, 2022 20:04
@digocorbellini digocorbellini self-assigned this Aug 11, 2022
Copy link
Contributor

@AustinSiu AustinSiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants