fix: Add CVE-2023-46809 option to integration node #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a CVE-2023-46809 to skip RSA_PKCS1_OAEP_PADDING test vectors. Adding a CI target to start node with --security-revert=CVE-2023-46809 and attempt RSA_PKCS1_OAEP_PADDING test vectors.
texastony
reviewed
Jul 5, 2024
josecorella
requested changes
Jul 5, 2024
Contributor
josecorella
left a comment
josecorella
left a comment
There was a problem hiding this comment.
can we update ci to run on latest node 18 and 20?
https://github.com/aws/aws-encryption-sdk-javascript/pull/1423/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR10
josecorella
approved these changes
Jul 5, 2024
Contributor
josecorella
left a comment
josecorella
left a comment
There was a problem hiding this comment.
adding 22 and latest?! Very nice 👏
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CVE-2023-46809 to skip
RSA_PKCS1_OAEP_PADDING test vectors.
Adding a CI target to start node
with --security-revert=CVE-2023-46809
and attempt RSA_PKCS1_OAEP_PADDING test vectors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: