Skip to content

chore: Fix credentials.expiration #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

chore: Fix credentials.expiration #1434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ function createCredentialPreprocessor() {
// This will affect the generated (ES5) JS
const regionCode = `var defaultRegion = '${region}';`
const credentialsCode = `var credentials = ${JSON.stringify(credentials)};`
// See: https://github.com/aws/aws-sdk-js-v3/issues/5890
const expirationNeedsToBeDate = `credentials.expiration = new Date(credentials.expiration);`
const isBrowser = `var isBrowser = true;`
const contents = content.split('\n')
let idx = -1
Expand All @@ -137,7 +139,7 @@ function createCredentialPreprocessor() {
break
}
}
contents.splice(idx + 1, 0, regionCode, credentialsCode, isBrowser)
contents.splice(idx + 1, 0, regionCode, credentialsCode, expirationNeedsToBeDate, isBrowser)
done(contents.join('\n'))
}
}