-
Notifications
You must be signed in to change notification settings - Fork 945
Implementing Protocol Rpc V2 Cbor FeatureID #6483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
S-Saranya1
wants to merge
9
commits into
master
Choose a base branch
from
somepal/cbor-feature-ID
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+916
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
requested changes
Oct 16, 2025
codegen/src/main/java/software/amazon/awssdk/codegen/poet/client/specs/JsonProtocolSpec.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Oct 16, 2025
...ests/src/test/java/software/amazon/awssdk/protocol/tests/ProtocolRpcV2CborUserAgentTest.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Oct 17, 2025
...s-core/src/main/java/software/amazon/awssdk/awscore/internal/AwsExecutionContextBuilder.java
Show resolved
Hide resolved
...ses-test/src/test/java/software/amazon/awssdk/services/rpcv2cbor/RpcV2CborUserAgentTest.java
Show resolved
Hide resolved
...ests/src/test/java/software/amazon/awssdk/protocol/tests/ProtocolRpcV2CborUserAgentTest.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Oct 17, 2025
...s-core/src/main/java/software/amazon/awssdk/awscore/internal/AwsExecutionContextBuilder.java
Outdated
Show resolved
Hide resolved
joviegas
reviewed
Oct 17, 2025
zoewangg
approved these changes
Oct 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
no-api-surface-area-change
Indicate there is no API surface area change and thus API surface area review is not required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add business metrics tracking support for PROTOCOL_RPC_V2_CBOR feature ID to track when an operation called using the Smithy RPC v2 CBOR protocol.
Motivation and Context
Enable business metrics tracking for RPC v2 CBOR protocol usage to understand protocol adoption.
Modifications
Added PROTOCOL_RPC_V2_CBOR("M") business metric feature ID to BusinessMetricFeatureId enum
Modified JsonProtocolSpec to add RPC v2 CBOR business metrics when the protocol is Smithy RPC V2
Testing
Added
ProtocolRpcV2CborUserAgentTest
to verify User-Agent header contains "M" metric for RPC v2 CBOR clients.Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License