Various updates #72
Closed
Various updates #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2024 12:32
- replaced emptyOnDelete by autoDeleteImages because of [WARNING] aws-cdk-lib.aws_ecr.RepositoryProps#autoDeleteImages is deprecated. Use `emptyOnDelete` instead. This API will be removed in the next major release.
- amended test case to reflect constructor signature change
[Warning at /biga-build-image/BuildImagePipeline] V1 pipeline type is implicitly selected when `pipelineType` is not set. If you want to use V2 type, set `PipelineType.V2`. [ack: @aws-cdk/aws-codepipeline:unspecifiedPipelineType] [Warning at /biga-build-ec2-ami/EmbeddedLinuxPipeline] V1 pipeline type is implicitly selected when `pipelineType` is not set. If you want to use V2 type, set `PipelineType.V2`. [ack: @aws-cdk/aws-codepipeline:unspecifiedPipelineType] [Warning at /biga-build-nxp-goldbox/EmbeddedLinuxPipeline] V1 pipeline type is implicitly selected when `pipelineType` is not set. If you want to use V2 type, set `PipelineType.V2`. [ack: @aws-cdk/aws-codepipeline:unspecifiedPipelineType]
thomas-roos
previously approved these changes
Nov 27, 2024
|
Could may resolve the conflicts? |
|
conflict resolved |
|
Thank you, can you look in fixing the check failures? |
|
need to revisit my changes as discovered tests ere not successful |
|
Ok, did just briefly look over the tests and it seemed that the NAG needs an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.