Skip to content

Conversation

NullSoldier
Copy link
Contributor

@NullSoldier NullSoldier commented Oct 7, 2025

What changed? Why?

These doc comments were in the latest docs, but this type was copied and didn't have the comment strings. Porting these to the older version of this doc.

Notes to reviewers

How has it been tested?

  1. npx mint dev
  2. Change version selection to 0.38.x
  3. In the navigation bar under Types click on Identity
  4. See that GetAttestationOptions is the only type without comments
  5. See that comments were back-ported in this commit to 0.38.x from Open http://localhost:3000/onchainkit/latest/utilities/identity/get-attestations

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 7, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@NullSoldier NullSoldier force-pushed the jason/update-type-comments branch 2 times, most recently from d70d1ab to c309203 Compare October 18, 2025 03:18
@NullSoldier NullSoldier requested a review from dgca October 18, 2025 03:25
@NullSoldier NullSoldier changed the title Added comments from type schema to types docs Added comments from type schema to types docs for 0.38.x Oct 18, 2025
@NullSoldier NullSoldier changed the title Added comments from type schema to types docs for 0.38.x Added comments for GetAttestationOptions for 0.38.x Oct 18, 2025
These doc comments were in the latest docs, but this type was copied and didn't have the comment strings. Porting these to the older version of this doc.
@NullSoldier NullSoldier force-pushed the jason/update-type-comments branch from c309203 to 6147240 Compare October 18, 2025 03:28
@youssefea youssefea merged commit f6dddfe into base:master Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants