-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Install xpadneo driver by default for Steam #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Prompts users during Steam installation to optionally install the xpadneo driver, which fixes common Xbox/Bluetooth controller issues including detection problems and missing rumble support.
I think we should just install this stuff to ensure that these common controllers just work out of the box. cc @ryanrhughes |
bin/omarchy-install-steam
Outdated
echo " • Bluetooth connectivity problems" | ||
echo "" | ||
read -p "Install controller fix? (y/N): " -n 1 -r | ||
echo "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cut all this. It should just add this directly.
bin/omarchy-install-steam
Outdated
echo "" | ||
|
||
if [[ $REPLY =~ ^[Yy]$ ]]; then | ||
echo "Setting up xpadneo enhanced controller support..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No output and no ask needed.
bin/omarchy-install-steam
Outdated
elif [[ $KERNEL == *"lts"* ]]; then | ||
sudo pacman -S --noconfirm linux-lts-headers | ||
else | ||
sudo pacman -S --noconfirm linux-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only support the default kernel by default, so just stick to that.
bin/omarchy-install-steam
Outdated
echo 'hid_xpadneo' | sudo tee /etc/modules-load.d/xpadneo.conf >/dev/null | ||
|
||
# Add input group permission | ||
sudo usermod -a -G input $USER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this require a reboot to take effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will require a reboot to take effect. Looks like I can add
omarchy-state set relaunch-required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I think this is ready for re-review @dhh
bin/omarchy-install-steam
Outdated
sudo usermod -a -G input $USER | ||
omarchy-state set relaunch-required | ||
|
||
setsid gtk-launch steam >/dev/null 2>&1 & |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that a restart is required, we can probably get rid of this line opening Steam
I tested this on a clean install of Omarchy. After a restart, I was able to connect my Xbox One Elite Series controller, get vibration and buttons working. I noticed an unrelated issue on my clean install, Nvidia drivers were automatically installed, instead of AMD drivers. I am on a framework 16 with the dGPU. I'd be happy to file an issue for this. (EDIT: adjacent issue #1441 - re: AMD drivers - I can pick this after on a different branch) |
Installs xpadneo driver automatically to ensure Xbox/Bluetooth controllers work out of the box.