-
Notifications
You must be signed in to change notification settings - Fork 127
Python Editor 1.1.0 changes #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When opening the editor.html I get the following error:
The line in python-main.js is 310: Lines 308 to 312 in 0e7c3a6
The problem is because now in the editor.html file we have: Lines 71 to 74 in 0e7c3a6
When did python-main remove that line? We should look at the git history and make sure we haven't missed a commit to cherry pick into this repo. |
|
Actually the question should have been, when was that line added to the bbcmicrobit/PythonEditor repository, which was the 16 Mar 2017: b02f045 When v1.1.0 was released, the last bbcmicrobit/PythonEditor commit in python-editor was from the 9th of Feb 2017. So we can just fix this line in a new commit. |
|
Everything else looks good, so I'll do a quick edit to this branch and merge. |
|
Just realised the branch is in your fork, so if you could add the fix, then merge and rebase all the other PRs. |
|
Think that should do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for merge, thanks Sam!
Updated uPy to 1.0.0
Added help box with version info