Skip to content

Fix an iOS reference in testbed cloning. #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

johnzhou721
Copy link
Contributor

However, this does NOT work. Somehow when I unpack the finished support package and find the testbed, this happens:

Screenshot 2025-04-23 at 5 26 12 PM

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@johnzhou721 johnzhou721 marked this pull request as ready for review April 23, 2025 22:35
@freakboy3742
Copy link
Member

Yup - that's a pretty glaring bug :-)

I guess this is an indication that we really should be running at least a "smoke test" of the distribution asset as part of the build. At present, the only test we're running is on iOS, and it uses the Python-Apple-standalone project, which would require a Briefcase backend for every platform. Running a minimal subset of the CPython test suite seems like an equally valid set of tests.

@freakboy3742 freakboy3742 merged commit f8fd686 into beeware:main Apr 23, 2025
6 checks passed
@johnzhou721
Copy link
Contributor Author

@freakboy3742 but what about the screenshot I put in? Something's going on with this at least on my end...

@freakboy3742
Copy link
Member

Given that the visionOS testbed was copying completely the wrong project, I assumed the screenshot was related to that. If it's not, then that's a separate bug that isn't "iOS reference in testbed cloning". My immediate guess would be that you haven't got 3.14.0a7 installed locally, but I could be wrong on that count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants