Skip to content

Remove some useless PATHs in Usage.md #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

johnzhou721
Copy link
Contributor

A lot of the PATHs are redundant in USAGE.md, so this PR removes them.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified these changes actually work?

There's a notable difference between the initialization sequence described in this document, and the initialization sequence used in the iOS testbed - but the difference isn't just what is put on to PYTHONPATH - its how the data is put onto PYTHONPATH, and the rest of the initialisation routine.

I agree that the three sources (this document, the iOS testbed, and the briefcase iOS template) should be consistent - but we need to make sure we're clear what is both consistent and correct.

@johnzhou721
Copy link
Contributor Author

johnzhou721 commented May 5, 2025 via email

@johnzhou721
Copy link
Contributor Author

Revised + Tested.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks like the instructions have inherited some baggage from the "isolated config" versions that the apps use.

@freakboy3742 freakboy3742 merged commit a041905 into beeware:main May 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants