Skip to content

Add More Dates #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Add More Dates #621

merged 3 commits into from
May 19, 2025

Conversation

johnzhou721
Copy link
Contributor

Fixes #619.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@johnzhou721 johnzhou721 marked this pull request as ready for review May 18, 2025 17:26
@freakboy3742 freakboy3742 added the preview Approved for an automated preview label May 18, 2025
Copy link

Visit the preview URL for this PR (updated for commit 2f1ba2b):

https://beeware-org--pr621-pycon2025-sm36vm76.web.app

(expires Sun, 25 May 2025 22:12:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec

@johnzhou721
Copy link
Contributor Author

@freakboy3742 https://beeware-org--pr621-pycon2025-sm36vm76.web.app/news/events/pycon-us-2025-tutorial/ has a stray None that I have no idea about. Also could you please tag beeware/Python-Apple-support#280 with preview? I want to try to add a mechanism to run the full test suite but only when tagged

@johnzhou721
Copy link
Contributor Author

Oh also forgot PyCon AU 2024

@freakboy3742
Copy link
Member

@freakboy3742 https://beeware-org--pr621-pycon2025-sm36vm76.web.app/news/events/pycon-us-2025-tutorial/ has a stray None that I have no idea about.

Well - that's something to investigate then.

Also could you please tag beeware/Python-Apple-support#280 with preview? I want to try to add a mechanism to run the full test suite but only when tagged

Please don't. That PR is about Mac Catalyst support. If you want to tackle beeware/Python-Apple-support#287 or beeware/Python-Apple-support#288, those are separate issues to Mac Catalyst. A PR should solve one problem, unless the two issues are irrevocably intertwined - and in this case, they're not.

And - once again - please ask questions about a PR on the PR that is affected, rather than spreading the conversation across repositories.

Lastly - you've responded to a bunch of PRs that I've opened in the last day or two. Could I ask that you please leave those alone for the moment. I've opened them specifically so that when the PyCon US sprints start tomorrow, there are simple tasks for first time contributors to work on. That's why they're tagged "Good First Issues". If you jump in an write patches for all of them, then it's harder for sprinters to find work to do.

@johnzhou721
Copy link
Contributor Author

@freakboy3742 https://beeware-org--pr621-pycon2025-sm36vm76.web.app/news/events/pycon-us-2025-tutorial/ has a stray None that I have no idea about.

Well - that's something to investigate then.

Will do.

Also could you please tag beeware/Python-Apple-support#280 with preview? I want to try to add a mechanism to run the full test suite but only when tagged

Please don't. That PR is about Mac Catalyst support. If you want to tackle beeware/Python-Apple-support#287 or beeware/Python-Apple-support#288, those are separate issues to Mac Catalyst. A PR should solve one problem, unless the two issues are irrevocably intertwined - and in this case, they're not.

Reset + force pushed.

Lastly - you've responded to a bunch of PRs that I've opened in the last day or two. Could I ask that you please leave those alone for the moment. I've opened them specifically so that when the PyCon US sprints start tomorrow, there are simple tasks for first time contributors to work on. That's why they're tagged "Good First Issues". If you jump in an write patches for all of them, then it's harder for sprinters to find work to do.

I'm not sure which PRs I've commented on -- do you mean issues? Also I've only responded to the spellchecker issue which I tried to do as I was involved in, but no worries about that since I have a bunch of stuff to do right now.

@johnzhou721
Copy link
Contributor Author

About stray None: It's not my issue, see http://beeware-org--pr621-pycon2025-sm36vm76.web.app/news/events/everything-open-2023/. However I will still try to figure out what's going on, but in the meantime I'll add the PyCon AU 2024 things and we could try to get this merged.

@johnzhou721
Copy link
Contributor Author

#622

@johnzhou721
Copy link
Contributor Author

Added PyCon AU 2024.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - I'll see If I can find someone to track down the None issue at the PyCon US sprints. Thanks for the extra metadata

@freakboy3742 freakboy3742 merged commit b0b7168 into beeware:lektor May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Approved for an automated preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyCon 2025 Things are Not Listed on Events
2 participants