deps: bump bdk to 1.0.0 #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
approved these changes
Jan 8, 2025
Member
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK 93edca7.
Maybe one little change if you agree with it, otherwise it's good to go either way.
bdk-ffi/Cargo.toml
Outdated
| bdk_core = { version = "0.4.0" } | ||
| bdk_esplora = { version = "0.20.0", default-features = false, features = ["std", "blocking", "blocking-https-rustls"] } | ||
| bdk_electrum = { version = "0.20.0", default-features = false, features = ["use-rustls-ring"] } | ||
| bdk_wallet = { version = "=1.0.0", features = ["all-keys", "keys-bip39", "rusqlite"] } |
Member
There was a problem hiding this comment.
I think we should be able to remove the = sign here and let cargo do its thing since new feature versions should not introduce breaking changes.
Collaborator
Author
There was a problem hiding this comment.
updated to remove the =
| bdk_electrum = { version = "0.20.1", default-features = false, features = ["use-rustls-ring"] } | ||
| bitcoin-ffi = { git = "https://github.com/bitcoindevkit/bitcoin-ffi", tag = "v0.1.2" } | ||
|
|
||
| uniffi = { version = "=0.28.0" } |
Member
There was a problem hiding this comment.
Don't do that for uniffi though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump to 1.0.0
Reworded next_unused_address docstring
Notes to the reviewers
Basically just updating deps, double checking from this PR
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: