test(wallet): create tx locktime cltv for a specific time #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3r10
changed the title
f3r10
force-pushed
the
test_timelock_descriptors
branch
from
a636a6b to
af30026
Compare
Contributor
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
tACK af30026
I just left a suggestion to fix a typo on the code comment.
f3r10
force-pushed
the
test_timelock_descriptors
branch
2 times, most recently
from
fd5d91a to
5471c3b
Compare
Collaborator
|
In 5471c3b: the commit doesn't appear to be signed |
f3r10
force-pushed
the
test_timelock_descriptors
branch
from
5471c3b to
f38b3eb
Compare
f3r10
force-pushed
the
test_timelock_descriptors
branch
from
f38b3eb to
2c11d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unit test that checks the satisfaction of timestamp-based timelocks. The goal is to test the absolute time therefore the variable passed to the miniscript fragment
afterhas to be equal to or greater that 500_000_000 otherwise it would be checking the block height.Notes to the reviewers
This unit test tries to check if bitcoindevkit/bdk_wallet#183 is still an issue.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing