Skip to content

Conversation

@evanlinjin
Copy link
Member

Description

The recent release of rustls (0.23.19) reverts it's MSRV to 1.63 so the pin is no longer necessary.

Notes to the reviewers

Some context:

Changelog notice

  • Revert MSRV pin of rustls.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

The recent release of `rustls` (0.23.19) reverts it's MSRV to 1.63 so
the pin is no longer necessary.
@evanlinjin evanlinjin added ci dependencies Pull requests that update a dependency file chore Non-coding related work labels Nov 29, 2024
@evanlinjin evanlinjin self-assigned this Nov 29, 2024
@LagginTimes
Copy link
Contributor

ACK 8e5a7c6

@LagginTimes
Copy link
Contributor

Since the release notes for 0.23.19 specify that all subsequent releases (0.23.20 and beyond) will have a MSRV of at least 1.71, would it be better to pin our CI to version 0.23.19?

@evanlinjin
Copy link
Member Author

Since the release notes for 0.23.19 specify that all subsequent releases (0.23.20 and beyond) will have a MSRV of at least 1.71, would it be better to pin our CI to version 0.23.19?

I think that will only make sense once we have a release that is > 0.23.18. Otherwise, pining to 0.23.19 will look like this:

cargo update -p [email protected] --precise "0.23.19"

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8e5a7c6

@ValuedMammal ValuedMammal merged commit 00c33c4 into bitcoindevkit:master Nov 29, 2024
21 checks passed
@notmandatory notmandatory mentioned this pull request Dec 12, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants