Skip to content

example_cli: add feerate option to psbt new cmd #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ValuedMammal merged 4 commits into from
Mar 20, 2025
Merged

example_cli: add feerate option to psbt new cmd #1840

ValuedMammal merged 4 commits into from
Mar 20, 2025

Conversation

@ValuedMammal
Copy link
Collaborator

@ValuedMammal ValuedMammal commented Feb 16, 2025 •
edited
Loading

The PR aims to add a --feerate option to the psbt New command.

Also in this PR:

  • bump bdk_coin_select to 0.4
  • fix collecting Assets and enable support for more descriptor types

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Feb 17, 2025
@ValuedMammal ValuedMammal added this to the 2.0.0 milestone Feb 17, 2025
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch 2 times, most recently from e66e131 to 4d754f3 Compare February 20, 2025 14:10
oleonardolima
oleonardolima reviewed Feb 25, 2025
View reviewed changes
oleonardolima
oleonardolima reviewed Feb 26, 2025
View reviewed changes
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch 2 times, most recently from 8d785bd to 1b51e61 Compare February 28, 2025 22:49
oleonardolima
oleonardolima approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 1b51e61

It looks good, you probably need a rebase so CI can run after #1867 lands.

@ValuedMammal ValuedMammal removed this from BDK Wallet Mar 5, 2025
@ValuedMammal ValuedMammal removed this from the 2.0.0 milestone Mar 5, 2025
@notmandatory notmandatory moved this to In Progress in BDK Chain Mar 6, 2025
@ValuedMammal ValuedMammal force-pushed the example/cli-feerate branch from 1b51e61 to 17280e5 Compare March 7, 2025 19:13
@ValuedMammal ValuedMammal mentioned this pull request Mar 16, 2025
Closed
3 tasks
oleonardolima
oleonardolima approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 17280e5

@ValuedMammal
example_cli: fix collect assets with for_each_key
1ab269e 
which allows creating txs for more descriptor types.
@ValuedMammal
feat(example_cli): add feerate option to psbt new cmd
3e640ff
@ValuedMammal
deps(example_cli): bump bdk_coin_select to 0.4
b9be1f4
@ValuedMammal
refactor(example_cli): clean up CLI docs
c855a09 
`--psbt` is a required arg for both Sign, Extract.

Change example_esplora --parallel-requests to 2 for easier
testing, debugging.
ValuedMammal
ValuedMammal commented Mar 20, 2025
View reviewed changes
Copy link
Collaborator Author

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c855a09

@ValuedMammal ValuedMammal merged commit 71bf53d into bitcoindevkit:master Mar 20, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in BDK Chain Mar 20, 2025
@ValuedMammal ValuedMammal deleted the example/cli-feerate branch March 20, 2025 17:56
@ValuedMammal ValuedMammal mentioned this pull request Apr 3, 2025
Closed
41 tasks
@ValuedMammal ValuedMammal mentioned this pull request Apr 30, 2025
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels

None yet

Projects

BDK Chain
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ValuedMammal @oleonardolima