Disallow unconfirmed coinbase #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LagginTimes
requested changes
Jun 13, 2025
Contributor
LagginTimes
left a comment
LagginTimes
left a comment
There was a problem hiding this comment.
Just need a rebase and this LGTM!
evanlinjin
force-pushed
the
fix/disallow-unconfirmed-coinbase
branch
from
5660720 to
6df8d14
Compare
The logic in `CanonicalIter` will consider txs that are anchored to blocks not in the best chain since they still can appear in the mempool. However, coinbase txs can never be unconfirmed - which the old logic failed to exclude.
evanlinjin
force-pushed
the
fix/disallow-unconfirmed-coinbase
branch
from
6df8d14 to
c84035e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic in
CanonicalIterincludes transactions anchored to blocks outside the best chain, since they may still appear in the mempool.However, coinbase transactions can never be unconfirmed—a case the previous logic failed to exclude.
Notes to the reviewers
Sorry for my previous oversight on this.
Changelog notice
Fixed: - During canonicalization, exclude coinbase transactions when considering txs that are anchored in stale blocks.Checklists
All Submissions:
cargo +nightly fmtandcargo clippybefore committingBugfixes:
* [ ] This pull request breaks the existing API