ci: replace grcov by cargo-llvm-cov #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
approved these changes
Jul 10, 2025
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ACK d6a19fc
Thank you for looking into this and describing the problem in detail.
nymius
force-pushed
the
ci/replace-grcov-by-cargo-llvm-cov
branch
from
d6a19fc to
1b1dade
Compare
nymius
force-pushed
the
ci/replace-grcov-by-cargo-llvm-cov
branch
from
1b1dade to
066c4cd
Compare
Contributor
Author
|
I replaced |
110CodingP
added a commit
to 110CodingP/bdk_redb
that referenced
this pull request
Jul 22, 2025
Stolen from nymius's [pr](bitcoindevkit/bdk#1986) on bitcoindevkit/bdk regarding the same.
110CodingP
added a commit
to 110CodingP/bdk_redb
that referenced
this pull request
Jul 22, 2025
Stolen from nymius's [pr](bitcoindevkit/bdk#1986) on bitcoindevkit/bdk regarding the same.
Collaborator
|
ACK 066c4cd |
16 tasks
kwsantiago
pushed a commit
to kwsantiago/bdk
that referenced
this pull request
Aug 5, 2025
066c4cd ci: replace grcov by cargo-llvm-cov (nymius) Pull request description: ### Description As explained in bitcoindevkit#1984 , I discovered some misreportings in the coverage information given by grcov. Fixes bitcoindevkit#1984 ### Notes to the reviewers The discussion about the tool to use is open, but I'm adding this PR to showcase how a change from `grcov` to `cargo-llvm-cov` would look like and the improvements in reporting this change will bring. [Look the report in `coveralls`](https://coveralls.io/github/nymius/bdk?branch=ci/replace-grcov-by-cargo-llvm-cov) to get a better perspective of them. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo +nightly fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK 066c4cd oleonardolima: ACK 066c4cd Tree-SHA512: d237fcc36efb6a4d3ccfaa371c2c70fc18ee40b48ca48f1230c5df6dca093f57bc1096927ddb15f9cae59a4640d9e34bf3ef1a309037e21fe0e8348e132bf38d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #1984 , I discovered some misreportings in the coverage information given by grcov.
Fixes #1984
Notes to the reviewers
The discussion about the tool to use is open, but I'm adding this PR to showcase how a change from
grcovtocargo-llvm-covwould look like and the improvements in reporting this change will bring. Look the report incoverallsto get a better perspective of them.Checklists
All Submissions:
cargo +nightly fmtandcargo clippybefore committing