ci: pin webpki-roots for MSRV compatibility
#1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
approved these changes
Jul 18, 2025
| cargo update -p base64ct --precise "1.6.0" | ||
| cargo update -p minreq --precise "2.13.2" | ||
| cargo update -p tracing-core --precise "0.1.33" | ||
| cargo update -p [email protected] --precise "1.0.1" |
Contributor
There was a problem hiding this comment.
nit: I wonder if there's a way to use the cargo package specification with a matching regex, in order to not need to update once another version is released. I've tried locally without success.
16 tasks
kwsantiago
pushed a commit
to kwsantiago/bdk
that referenced
this pull request
Aug 5, 2025
e1c8891 ci: pin `webpki-roots` for MSRV compatibility (Wei Chen) Pull request description: ### Description This PR pins the `webpki-roots` crate to version 1.0.1 to maintain compatibility with our current MSRV. ### Changelog notice - Pin `webpki-roots` to 1.0.1 for MSRV compatibility. ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) ACKs for top commit: oleonardolima: ACK e1c8891 evanlinjin: ACK e1c8891 Tree-SHA512: 9849cf47f6c269b100374d4c32591ea0caa70f40f0249ead6e5364862f939efff1dffb612d5760622c6389d38874c7c238f4774c019e483ce6dcd826939d653d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pins the
webpki-rootscrate to version 1.0.1 to maintain compatibility with our current MSRV.Changelog notice
webpki-rootsto 1.0.1 for MSRV compatibility.Checklists
All Submissions: