-
Notifications
You must be signed in to change notification settings - Fork 912
[PM-27736] Add FIDO privileged allowlist entry for vivo FIDO client (com.fido.client) #6114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6114 +/- ##
==========================================
- Coverage 84.84% 84.82% -0.03%
==========================================
Files 733 735 +2
Lines 53014 53136 +122
Branches 7669 7669
==========================================
+ Hits 44982 45072 +90
- Misses 5344 5376 +32
Partials 2688 2688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @zy6p I'm unable to verify the package signature from official sources, and unfortunately I don't have a Vivo phone available to validate, myself. Could you elaborate on how you retrieved the signature and include a video of it working after the change, and how it behaved prior to the change? |
lv_0_20251106221428.mp4
lv_0_20251106220959.mp4
lv_0_20251106221139.mp4 |

🎟️ Tracking
Community contribution to improve passkey support on vivo devices.
com.fido.clientis the preinstalled vivo FIDO / passkey client on recent OriginOS builds.This PR adds it to the community FIDO privileged allowlist so that Bitwarden can be used as a passkey provider when the system FIDO UI is involved.
📔 Objective
On recent vivo devices (e.g., OriginOS on Android 14), passkey flows that are routed through the system FIDO UI (
com.fido.client) fail with:The objective of this PR is to treat the vivo system FIDO client as a trusted FIDO caller, similar to IronFox Nightly in PR #6046, by adding an entry for
com.fido.client(with its SHA-256 certificate fingerprint) toapp/src/main/assets/fido2_privileged_community.json.This allows Bitwarden to successfully complete passkey registration and authentication when
com.fido.clientmediates the request.📸 Screenshots
Not applicable – no UI changes.
Verification was performed by:
com.fido.client.com.fido.clientwithout the “not on the privileged list” error.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes