Skip to content

Update README.md to clarify specifying orientation from Exif data #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2016

Conversation

Nateowami
Copy link
Contributor

Clarified how to use the orientation option, and changed wording regarding the Exif parser.

Regarding the orientation option, from the original wording I thought the meaning was that you could simply enable the orientation option (e.g. by setting it to true), but from reading the source code for the demo, I see you have to determine the orientation separately with the loadImage.parseMetaData function.

On a side note, it might be worth making it an option to correct the orientation in a single function call. Fixing the orientation is the single reason I'm using this library (HTMLImageElement provides decent functionality out of the box), and I'm guessing the same could be for many others users of this library.

Thoughts on my proposed wording changes? I'm not completely happy with the wording I cam up with, but it seems clearer to me than the original wording.

@blueimp blueimp merged commit 202f10e into blueimp:master Oct 8, 2016
@blueimp
Copy link
Owner

blueimp commented Oct 8, 2016

Thanks @Nateowami, I've also just added the new options meta:true and orientation:true:
https://github.com/blueimp/JavaScript-Load-Image#options

@Nateowami
Copy link
Contributor Author

Thanks, that's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants