Update README.md to clarify specifying orientation from Exif data #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified how to use the
orientation
option, and changed wording regarding the Exif parser.Regarding the orientation option, from the original wording I thought the meaning was that you could simply enable the
orientation
option (e.g. by setting it totrue
), but from reading the source code for the demo, I see you have to determine the orientation separately with theloadImage.parseMetaData
function.On a side note, it might be worth making it an option to correct the orientation in a single function call. Fixing the orientation is the single reason I'm using this library (
HTMLImageElement
provides decent functionality out of the box), and I'm guessing the same could be for many others users of this library.Thoughts on my proposed wording changes? I'm not completely happy with the wording I cam up with, but it seems clearer to me than the original wording.