-
Notifications
You must be signed in to change notification settings - Fork 8
Update README.MD #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix typo in the proper GA metric to select. You have to type "page views" with the space to get the right suggestion.
@SalimBensiali Thank you for the pull request. I am unable to reproduce the behavior you describe. When I type "pageviews", I get the suggestion, but when I type "page views", I do not (see images below). |
Thanks for looking into this @galvarez421 , I get the opposite behaviour though: I guess it highly depends on how GA is configured. Not sure what to do about that. |
May I ask a couple of things? In Google Analytics,
I'm just trying to figure out the exact cause of the language difference so the documentation can clearly indicate why language deviations may be observed. |
Hi @galvarez421, thanks for following up on this.
I see "English (United Kingdom)"
I see "Ireland" |
Thanks! So I did some testing and it turns out that the user language setting is the root cause of the wording difference. There are 6 versions of English included as language options, including United States, United Kingdom, and Ireland. As a matter of practicality, we cannot fully account for all or even multiple languages (although something like github/markup#899 might eventually be desirable). At the same time, I am certainly not against making the documentation more accessible if the initial and ongoing cost is relatively small. Since there are currently only 6 versions of English to account for and all versions except for United States use "Page Views", I think it would make sense to list both variations side by side, i.e.:
My rationale for including the United States variation and listing it before the non-US variation is that, according to https://octoverse.github.com/people, the US accounts for most GitHub contributors as of 2018. I would also recommend the following:
we make it this:
Let me know what you think. |
Thanks @galvarez421, this sounds good to me. Did you want me to action anything on my PR? Cheers for looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #5 (comment), can you please change the wording to be the following?
- **Metrics**: Pageviews or Page Views
Feel free to also include the other wording change described at the bottom of the linked comment.
I will take care of the Google Analytics language audit I described ("review all other relevant wording (metrics, dimensions, etc.) in the 6 English variations to check whether there are other language variations that we think might be good to account for in the documentation.").
Thanks!
Update wording as per review feedback
Done. Thanks again @galvarez421! |
- Add instruction and explanation regarding the need to set user language setting to US English. Close #14. - Because of the above change, remove parenthetical note regarding how language may vary depending on user language settings and remove alternate spelling of "Pageviews" introduced in #5. - Remove unnecessary section regarding "Views" section of custom report.
Fix typo in the proper GA metric to select. You have to type "page views" with the space to get the right suggestion.