Downgrade celo-token-signer to fix inability to transfer dollars on ledger. #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I after experimenting with various versions of the celo-token-signer and various tokens. I believe the problem is that when 0.14 introduced bringing in tokens from the celo-token-list it used their name and not symbol for the ticker and the deduping algo meant that the celo-token-list overwrote the whitelist tokens.
reverting to 0.13 to temp fix this.
Other changes
n/a
Tested
transfered usdm successfully
How to QA
try to send dollars and other tokens.
Related issues
celo-org/celo-ledger-token-signer#29
PR-Codex overview
This PR focuses on downgrading the version of
@celo/ledger-token-signerfrom0.14.0to0.13.0across multiple package files to resolve an issue with transferring dollars on the ledger.Detailed summary
@celo/ledger-token-signerfrom0.14.0to0.13.0in:packages/viem-account-ledger/package.jsonpackages/sdk/wallets/wallet-ledger/package.jsonyarn.lockto reflect the new version of@celo/ledger-token-signer.