Skip to content

Conversation

@aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Dec 19, 2025

Description

I after experimenting with various versions of the celo-token-signer and various tokens. I believe the problem is that when 0.14 introduced bringing in tokens from the celo-token-list it used their name and not symbol for the ticker and the deduping algo meant that the celo-token-list overwrote the whitelist tokens.

reverting to 0.13 to temp fix this.

Other changes

n/a

Tested

transfered usdm successfully

How to QA

try to send dollars and other tokens.

Related issues

celo-org/celo-ledger-token-signer#29


PR-Codex overview

This PR focuses on downgrading the version of @celo/ledger-token-signer from 0.14.0 to 0.13.0 across multiple package files to resolve an issue with transferring dollars on the ledger.

Detailed summary

  • Downgraded @celo/ledger-token-signer from 0.14.0 to 0.13.0 in:
    • packages/viem-account-ledger/package.json
    • packages/sdk/wallets/wallet-ledger/package.json
  • Updated yarn.lock to reflect the new version of @celo/ledger-token-signer.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@aaronmgdr aaronmgdr requested a review from a team as a code owner December 19, 2025 13:39
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: 4ef63b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@celo/wallet-ledger Patch
@celo/viem-account-ledger Patch
@celo/celocli Patch
@celo/wallet-base Patch
@celo/wallet-hsm-aws Patch
@celo/wallet-hsm-azure Patch
@celo/wallet-hsm-gcp Patch
@celo/wallet-hsm Patch
@celo/wallet-local Patch
@celo/wallet-remote Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

size-limit report 📦

Path Size
require('@celo/actions') (cjs) 98.85 KB (0%)
import * from '@celo/actions' (esm) 23.55 KB (0%)
import { resolveAddress } from '@celo/actions' (esm) 23.49 KB (0%)
import { getGasPriceOnCelo } from '@celo/actions' (esm) 73 B (0%)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm) 46.11 KB (0%)
import * from '@celo/actions/staking' (esm) 50.66 KB (0%)

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.63%. Comparing base (d5d9043) to head (4ef63b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files         150      150           
  Lines        7071     7071           
  Branches     1153     1153           
=======================================
  Hits         4924     4924           
- Misses       2055     2097   +42     
+ Partials       92       50   -42     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.15% <ø> (ø)
wallets 73.14% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

celocli transfer:dollars fails with Ledger "Invalid data received (0x6a80)"

2 participants