Fixed PHPDocumentation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our application was expecting a boolean to be returned by the auth() function. However, this seems to have been changed overtime. How is determined whether an authentication is successful? It seems the only way is to use 'checkToken()' after authentication. It would be better to have 'setToken()' return a boolean, however this might break other stuff that depends on the $this being returned now...
Contributor
|
If the auth request fails an exception is thrown. The checkToken() is meant to verify that a token exist. Thank you for the pull request |
Contributor
Author
|
Can you guys consider to tag the current master as a new version? So our production systems (not allowed to depend on development versions) can also incorporate these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application was expecting a boolean to be returned by the auth() function. However, this seems to have been changed overtime. How is determined whether an authentication is successful? It seems the only way is to use 'checkToken()' after authentication.
It would be better to have 'setToken()' return a boolean, however this might break other stuff that depends on the $this being returned now...