Ensure that we pass in the current endpoint (webSocket.getNamespace()) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) when creating an IOMessage.
clwillingham
added a commit
that referenced
this pull request
Jun 22, 2012
Ensure that we pass in the current endpoint (webSocket.getNamespace())
|
thanks for sending in the pull request, i'm sorry i haven't had much time to work on this library. I've gotten a new job which requires a bit more of my time, however i will do my best to get this project a bit more up to date soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was able to get your library working with a node.js socket.io server using endpoints, but only after making the proposed changes.
Fred