webapp: new APIs #585
Merged
webapp: new APIs #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cpirich
commented
Dec 1, 2014
cpirich
commented
- added createTextLabel, setPosition, setParent
- added canvasSetStrokeColor, canvasSetLineWidth, canvasSetFillColor
- add width,height parameters to createCanvas - optional
- changed generateDropletPalette() to create multiple categories if categoryInfo is passed in
- leveraged this new change for webapp by creating a separate Canvas category in droplet
| return false; | ||
| }; | ||
|
|
||
| Webapp.canvasSetLineWidth = function (opts) { |
There was a problem hiding this comment.
A brief comment on each of these methods would be helpful, at least listing which properties on "opts" are being used.
|
LGTM |
deploy-code-org
added a commit
that referenced
this pull request
Dec 1, 2014
commit c8175d8 Merge: a27a5c0 99b0ab5 Author: cpirich <[email protected]> Date: Mon Dec 1 11:02:39 2014 -0800 Merge pull request #585 from code-dot-org/webapp_new_APIs webapp: new APIs commit 99b0ab5 Author: cpirich <[email protected]> Date: Mon Dec 1 11:01:23 2014 -0800 make fillColor work commit a27a5c0 Author: Tanya Parker <[email protected]> Date: Mon Dec 1 10:53:54 2014 -0800 add support contact to hourofcode.com/ro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.