feat: configurable auto-close and enhanced terminal architecture

[ThomasK33]

Summary

• Add configurable auto_close option (default: true) to control terminal lifecycle behavior
• Refactor terminal module into clean provider architecture with separate snacks and native implementations
• Simplify state management using reliable :buf_valid() approach instead of complex state tracking
• Remove Snacks.terminal.get() usage to avoid invalid instance caching bugs
• Add comprehensive error reporting with detailed diagnostic context
• Fixes [FEATURE] Open Claude code with --continue or --resume option #17: Add support for --continue and --resume command arguments

Key Features

Command Arguments Support (Fixes #17)

• :ClaudeCode --resume: Resume a specific Claude session as requested in [FEATURE] Open Claude code with --continue or --resume option #17
• :ClaudeCode --continue: Continue previous work when restarting Neovim or PC as requested in [FEATURE] Open Claude code with --continue or --resume option #17
• :ClaudeCode [any arguments]: Pass any arguments directly to the claude command
• Backward compatible: Existing :ClaudeCode usage works exactly as before

Configurable Auto-Close Behavior

• auto_close = true (default): Terminal automatically closes after command completion with error notifications for failed commands
• auto_close = false: Terminal stays open for output review, useful for debugging and seeing detailed command results

Enhanced Terminal Architecture

• Modular provider system: Clean separation between snacks and native terminal providers
• Single creation path: Both open() and toggle() use consistent terminal creation logic through M.open()
• Reliable state management: Uses :buf_valid() for terminal validity checks instead of complex state variables
• Improved error handling: Detailed diagnostic context when terminal creation fails

Developer Experience Improvements

• Enhanced error reporting: Specific failure reasons with full context (command, options, validation details)
• LSP type definitions: Added vim.v definitions to eliminate LSP warnings
• Complete documentation: README updated with auto_close examples and usage guidance
• Development configuration: Updated dev-config.lua with auto_close example

Technical Changes

• Eliminated problematic Snacks.terminal.get() calls that returned invalid cached instances
• Removed terminal_state complexity in favor of simple buffer validity checks
• Added conditional event handlers that only create TermClose listeners when auto_close is enabled
• Maintained 100% API compatibility while improving reliability and user experience
• Added command argument parsing to support --resume, --continue, and any other claude CLI options

Test Results

• All tests passing: 237 successes / 0 failures / 0 errors
• Code quality clean: 0 warnings / 0 errors in 64 files
• Backward compatible: Default behavior unchanged, all existing functionality preserved

Files Changed

• lua/claudecode/terminal.lua: Refactored to provider dispatcher with command argument support
• lua/claudecode/terminal/snacks.lua: Clean snacks provider implementation
• lua/claudecode/terminal/native.lua: Clean native provider implementation
• lua/claudecode/init.lua: Updated command registration to support arguments
• README.md: Added auto_close documentation and command argument examples
• dev-config.lua: Added development configuration template
• lua/claudecode/meta/vim.lua: Added vim.v type definitions
• Updated tests and integration specs for new architecture

This refactoring significantly improves terminal reliability while adding user-requested configurability for terminal lifecycle management and command argument support.

[Copilot]

Pull Request Overview

This PR refactors the terminal module to introduce a configurable auto-close behavior, a modular provider system supporting both snacks and native implementations, and enhanced command argument support. Key changes include adjusting tests to reflect the new provider API, updating command registrations and documentation, and simplifying state management in terminal operations.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/unit/terminal_spec.lua	Updated tests to use the new provider interface and verify command argument handling.
tests/unit/init_spec.lua	Added tests for command registration and argument parsing for ClaudeCode commands.
tests/integration/command_args_spec.lua	Integration tests ensuring proper appending of command arguments and native terminal fallback.
lua/claudecode/terminal/snacks.lua	Redesigned snacks provider with auto-close and error handling improvements.
lua/claudecode/terminal/native.lua	Introduced native terminal provider with command argument support and state recovery logic.
lua/claudecode/meta/vim.lua	Added vim.v typing to support LSP type hints.
lua/claudecode/init.lua	Updated command registrations to pass along command arguments.
dev-config.lua	Provided updated development configuration examples.
README.md	Documentation updated with new command usage examples and auto_close behavior details.

Comments suppressed due to low confidence (1)

tests/unit/terminal_spec.lua:460

• [nitpick] Consider updating the test case description to clearly reflect the expected behavior of focusing an existing terminal and invoking provider open accordingly for clarity and maintainability.

it("should call provider open twice when terminal exists", function()

[Copilot]

[nitpick] Consider extracting the command argument parsing logic into a helper function to improve readability and maintainability of the command registration code.

Suggested change

	local cmd_args = opts.args and opts.args ~= "" and opts.args or nil
	local cmd_args = parse_command_args(opts)