Skip to content

[Chore]: Switch from yarn to a submodule #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsjoeio opened this issue Feb 23, 2022 · 0 comments · Fixed by #4990
Closed

[Chore]: Switch from yarn to a submodule #4901

jsjoeio opened this issue Feb 23, 2022 · 0 comments · Fixed by #4990
Assignees
@code-asher
Labels
chore Related to maintenance or clean up high-priority This issue needs to be resolved ASAP
Milestone
4.2.0

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 23, 2022

We currently use yarn link to create a symlink between vendor/modules/code-oss-dev and coder/vscode (our fork). This is a bit unreliable and also requires cloning and updating two separate repos. The first step then would be to switch away from yarn link and use a submodule.

  1. Remove vendor
  2. Add git submodule under lib/vscode
  3. update all the paths and the scripts to point to that location

There may be some additional code to cleanup
@jsjoeio jsjoeio added high-priority This issue needs to be resolved ASAP chore Related to maintenance or clean up labels Feb 23, 2022
@jsjoeio jsjoeio added this to the On Deck - High Priority milestone Feb 23, 2022
@jsjoeio jsjoeio mentioned this issue Feb 23, 2022
Closed
@jsjoeio jsjoeio assigned code-asher and unassigned jsjoeio Mar 2, 2022
code-asher added a commit to code-asher/code-server that referenced this issue Mar 14, 2022
@code-asher
Move Code to a submodule
8158668 
Closes coder#4901.
@code-asher code-asher mentioned this issue Mar 14, 2022
Merged
code-asher added a commit to code-asher/code-server that referenced this issue Mar 14, 2022
@code-asher
Move Code to a submodule
92c185d 
Closes coder#4901.
code-asher added a commit to code-asher/code-server that referenced this issue Mar 14, 2022
@code-asher
Move Code to a submodule
98053a0 
Closes coder#4901.
code-asher added a commit that referenced this issue Mar 15, 2022
@code-asher
chore: move Code to a submodule (#4990)
21c7480 
* Move Code to a submodule

Closes #4901.

* Base Code cache on hash and re-enable node_modules cache

The current setup appears to only rebuild VS Code if the dependencies
change but we need to rebuild it if anything changes.

I also re-enabled the commented out node_modules caches.  They look like
they should work to me with the submodule method.  I think the problem
occurred because Code itself was being installed in the yarn step.
TinLe pushed a commit to TinLe/code-server that referenced this issue Apr 23, 2022
@code-asher @TinLe
chore: move Code to a submodule (coder#4990)
9cb9d24 
* Move Code to a submodule

Closes coder#4901.

* Base Code cache on hash and re-enable node_modules cache

The current setup appears to only rebuild VS Code if the dependencies
change but we need to rebuild it if anything changes.

I also re-enabled the commented out node_modules caches.  They look like
they should work to me with the submodule method.  I think the problem
occurred because Code itself was being installed in the yarn step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
chore Related to maintenance or clean up high-priority This issue needs to be resolved ASAP
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

chore: move Code to a submodule code-asher/code-server
3 participants
@jawnsy @jsjoeio @code-asher