Clone exact vscode release branch when build task #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeasonstudio
changed the title
kylecarbs
approved these changes
Mar 9, 2019
|
I believe the release is 1.32.0 |
jeasonstudio
changed the title
kylecarbs
approved these changes
Mar 10, 2019
|
This broke local builds. |
|
Because the checkout was removed. |
|
Ah. We can revert this. |
|
A bit confused how the CI passed |
|
CI clones every time the exact release after this PR. When we try and reuse the existing lib/vscode directory, this PR makes it not checkout the exact release. |
|
Will include fix in my upcoming PR. |
nhooyr
added a commit
that referenced
this pull request
Mar 10, 2019
nhooyr
added a commit
that referenced
this pull request
Mar 10, 2019
andreimc
added a commit
to devonlineco/code-server
that referenced
this pull request
Mar 11, 2019
* upstream/master: (35 commits) Dockerfile: use relative path instead of $PWD for CMD Update docker oneliner and fix clone task Clone exact vscode release branch when build task (coder#167) Add -t flag to docker example (coder#181) Reverts parts of my last PR (coder#177) Fix build and Dockerfile issues (coder#176) Add nginx reverse proxy guide for selfhosted Use a timing-safe equality check for passwords (coder#133) Open websocket on same path as page (coder#149) Adhere to XDG base directory spec for dataDir and logDir (coder#156) Improve github issue template (coder#162) Fix typo: environemnt -> environment (coder#159) Add back web class Move upx compression behind an env flag ci: enable travis npm cache (coder#110) Improve .dockerignore (coder#111) Feature/1.32.0 update (coder#117) Update grammar on README (coder#139) inital -> initial (coder#135) Handle arch in dockerfile and add PR template (coder#109) ...
kylecarbs
pushed a commit
that referenced
this pull request
Mar 11, 2019
* Dockerfile: fix ENTRYPOINT must be provided in exec form for args from docker run to be passed correctly. See https://docs.docker.com/engine/reference/builder/#cmd * build: fix reuse of vscode repository regression See #167
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
* chore: clone exactly release branch when build * fix: clone params
code-asher
pushed a commit
that referenced
this pull request
Jun 19, 2019
* Dockerfile: fix ENTRYPOINT must be provided in exec form for args from docker run to be passed correctly. See https://docs.docker.com/engine/reference/builder/#cmd * build: fix reuse of vscode repository regression See #167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Build toooo slow.
Is there an open issue you can link to?