Skip to content

Added ENTRYPOINT to omit full command at launch. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added ENTRYPOINT to omit full command at launch. #170

wants to merge 1 commit into from

Conversation

ay-b
Copy link

@ay-b ay-b commented Mar 9, 2019

Having code-server at the ENTRYPOINT will free the CMD line, so launching that container will no longer require writing the binary name after image name and will not confuse people anymore.

@ay-b
Added ENTRYPOINT to omit full command at launch.
69b08f0 
Moving `code-server` to ENTRYPOINT will allow omitting it from the CLI launch.
@ay-b ay-b requested a review from nhooyr as a code owner March 9, 2019 13:20
@nhooyr nhooyr mentioned this pull request Mar 9, 2019
Closed
nhooyr
nhooyr suggested changes Mar 9, 2019
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify the README.md as well to account for this.

You cannot modify the CMD instruction for now until code-server accepts . properly. Exec form CMD's don't expand variables.

Please leave it as it is.

nhooyr added a commit that referenced this pull request Mar 9, 2019
@nhooyr
Dockerfile: add default Entrypoint and mount data dir
9cb4b5c 
Closes #170
Closes #78

Thanks @ay-b
@kylecarbs kylecarbs closed this in f375335 Mar 9, 2019
@ay-b
Copy link
Author

ay-b commented Mar 9, 2019

I don't know where the agrument logic lives, but at least as a workaround in it to replace " . " with " $PWD " before actual submitting to binary should work. Isn't it?

@nhooyr
Copy link
Contributor

nhooyr commented Mar 9, 2019

Sorry, I don't understand. Could you elaborate? Are you asking why . doesn't work?

@ay-b
Copy link
Author

ay-b commented Mar 9, 2019

Sorry, I don't understand. Could you elaborate? Are you asking why . doesn't work?

I don't know why it doesn't work — didn't see the code, sorry. But replacing the " . " argument with the " $PWD " prior the arguments get worked out should do the trick.

I'm sorry if I'm speaking nonsense.

@nhooyr
Copy link
Contributor

nhooyr commented Mar 9, 2019

Ah looks like this was fixed to work now: #19

I will update. Thanks.

code-asher pushed a commit that referenced this pull request Jun 19, 2019
@nhooyr @kylecarbs
Fix build and Dockerfile issues (#176)
d4f7328 
* build: fix yarn corruption issues

Closes #100

Thanks @zerdos

* Dockerfile: add default Entrypoint and mount data dir

Closes #170
Closes #78

Thanks @ay-b
nhooyr added a commit that referenced this pull request Jan 27, 2020
@nhooyr
Remove buggy -v flag from README.md docker run
41d1644 
Closes #170

Will describe in FAQ how to keep state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr requested changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ay-b @nhooyr @kylecarbs