Use proxy-agent to support $HTTP_PROXY #2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
requested changes
Dec 4, 2020
nhooyr
force-pushed
the
HTTP_PROXY-7e1f
branch
6 times, most recently
from
5c5adb5 to
d2f3e6c
Compare
|
Confirmed working, this should be good now! |
nhooyr
force-pushed
the
HTTP_PROXY-7e1f
branch
from
c10863e to
641a748
Compare
File names should not have dashes.
Closes #124 This works by monkey patching the http and https modules's default agent at runtime to the one given by the proxy-agent package.
From my inspection as of this date anyway.
nhooyr
force-pushed
the
HTTP_PROXY-7e1f
branch
from
641a748 to
bd6917d
Compare
code-asher
requested changes
Dec 4, 2020
buildfile.entrypoint ignores all args now and is hard coded to use these strings as exclude.
The previously used version seems to be buggy. I was seeing undefined errors when using a logger.named logger at level info.
Closes #2364 See #2366 cc @code-asher My previous commit didn't fix anything but still good to update @coder/logger.
nhooyr
force-pushed
the
HTTP_PROXY-7e1f
branch
from
9855ccb to
58bbf25
Compare
code-asher
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
This works by monkey patching the http and https modules's default agent
at runtime to the one given by the proxy-agent package.