Skip to content

cli: add --home flag to customize "Go Home" button #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 15, 2020
Merged

cli: add --home flag to customize "Go Home" button #2435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8daba6c
feat: add home as a cli option
jsjoeio Dec 9, 2020
157eeab
chore: generate new patch
jsjoeio Dec 9, 2020
00bd9e5
docs: update FAQ with new go home customization
jsjoeio Dec 9, 2020
f84174e
docs: fix typo in docs
jsjoeio Dec 9, 2020
77ddac2
chore: fix lint issue in patch
jsjoeio Dec 9, 2020
b1282b9
refactor: fix bug in --home test
jsjoeio Dec 10, 2020
90aa6f2
chore: format FAQ
jsjoeio Dec 10, 2020
066ce21
fix: remove unused import in workbench.ts
jsjoeio Dec 10, 2020
c266d4a
chore: revert accidental yarnlock changes in patch
jsjoeio Dec 14, 2020
b0336e9
chore: revert yarn.lock to match master
jsjoeio Dec 14, 2020
71abff7
Revert yarn.lock to master
nhooyr Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: add home as a cli option
  • Loading branch information
@jsjoeio
jsjoeio committed Dec 14, 2020
commit 8daba6ca80c082e719ec59dfd21d55436d90ee9a
5 changes: 5 additions & 0 deletions src/node/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export interface Args extends VsArgs {
"new-window"?: boolean

link?: OptionalString
home?: string
}

interface Option<T> {
Expand Down Expand Up @@ -198,6 +199,10 @@ const options: Options<Required<Args>> = {
`,
beta: true,
},
home: {
type: "string",
description: "Set a custom link for the 'Go Home' button in the Application Menu",
},
}

export const optionDescriptions = (): string[] => {
Expand Down
1 change: 1 addition & 0 deletions test/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ describe("parser", () => {
"extra-extensions-dir": [path.resolve("nozzle")],
help: true,
host: "0.0.0.0",
home: "https://localhost:8080/",
json: true,
log: "error",
open: true,
Expand Down