Skip to content

feat(lib/vscode): add log out to application menu #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2021
Merged

feat(lib/vscode): add log out to application menu #2922

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f790fd
feat(lib/vscode): add log out to application menu
jsjoeio Mar 17, 2021
5cec620
refactor: add cookie.ts to lib/vscode
jsjoeio Mar 17, 2021
090687d
feat: add e2e test for logout
jsjoeio Mar 17, 2021
9eff1f0
fix: add timeout to logout test
jsjoeio Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: add timeout to logout test
  • Loading branch information
@jsjoeio
jsjoeio committed Mar 23, 2021
commit 9eff1f070249627e0434aaefcf6743731875721b
7 changes: 2 additions & 5 deletions test/e2e/logout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,8 @@ describe("logout", () => {
await page.hover(logoutButton)

await page.click(logoutButton)
// it takes a second to navigate
// and since page.url comes back immediately
// we need this waitForNavigation, otherwise it will check
// before navigation has finished and fail
await page.waitForNavigation({ url: `${CODE_SERVER_ADDRESS}/login` })
// it takes a couple seconds to navigate
await page.waitForTimeout(2000)
const currentUrl = page.url()
expect(currentUrl).toBe(`${CODE_SERVER_ADDRESS}/login`)
})
Expand Down