Skip to content

fix(ci): upgrade runner to ubuntu-18.04 #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 21, 2021

Summary

This PR upgrades the Ubuntu runner 16.04 -> 18.04 for the package-linux-cross job in CI.

Context

4 days ago, CI was working as expected.

Yesterday, it stopped working.

After talking to @jawnsy, he shared with me that GitHub's infrastructure discontinued ubuntu-16.04: https://github.com/actions/virtual-environments/pull/3862/files on September 20th

image

Therefore, we have no other choice but to upgrade to 18.04.

Will this break anything? it shouldn't (famous last words)

Ubuntu 16.04 (Xenial Xerus) had glibc 2.23 and Ubuntu 18.04 (Bionic Beaver) has glibc 2.27, so I believe this may raise our minimum version requirement to 2.27: https://launchpad.net/ubuntu/+source/glibc
It looks like that version was released in early 2018, so that should be fine: https://sourceware.org/legacy-ml/libc-announce/2018/msg00000.html

@jawnsy

Fixes N/A

@jsjoeio jsjoeio self-assigned this Sep 21, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Sep 21, 2021
@github-actions
Copy link

✨ Coder.com for PR #4218 deployed! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as ready for review September 21, 2021 18:36
@jsjoeio jsjoeio requested a review from a team as a code owner September 21, 2021 18:36
@jsjoeio jsjoeio merged commit 1440b26 into main Sep 21, 2021
@jsjoeio jsjoeio deleted the jsjoeio-update-runners branch September 21, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants