Skip to content

feat(testing): add new test for cli.ts #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

feat(testing): add new test for cli.ts #4898

merged 2 commits into from
Feb 24, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Feb 22, 2022

This PR adds a test to ensure we have coverage for this block:

https://github.com/coder/code-server/blob/main/src/node/cli.ts#L358-L360

Fixes #4885

@jsjoeio jsjoeio added the testing Anything related to testing label Feb 22, 2022
@jsjoeio jsjoeio self-assigned this Feb 22, 2022
@jsjoeio jsjoeio requested a review from a team February 22, 2022 22:12
@jsjoeio jsjoeio temporarily deployed to CI February 22, 2022 22:12 Inactive
@jsjoeio jsjoeio temporarily deployed to npm February 22, 2022 22:21 Inactive
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #4898 (c85ace5) into main (f9402a6) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4898      +/-   ##
==========================================
+ Coverage   69.79%   69.86%   +0.06%     
==========================================
  Files          29       29              
  Lines        1649     1649              
  Branches      363      363              
==========================================
+ Hits         1151     1152       +1     
+ Misses        424      423       -1     
  Partials       74       74              
Impacted Files Coverage Δ
src/node/cli.ts 84.35% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9402a6...c85ace5. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

✨ Coder.com for PR #4898 deployed! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to CI February 22, 2022 22:24 Inactive
@jsjoeio jsjoeio temporarily deployed to npm February 22, 2022 22:33 Inactive
@jsjoeio jsjoeio merged commit 793e4d3 into main Feb 24, 2022
@jsjoeio jsjoeio deleted the jsjoeio-4885 branch February 24, 2022 18:07
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* feat(testing): add new test for cli.ts

* fixup!: update parse test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: add more coverage for parse function in cli.ts
2 participants