Skip to content

fix: add missing package.json and source maps #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2022
Merged

fix: add missing package.json and source maps #5040

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d9b15e
Use --exclude to skip node_modules
code-asher Mar 29, 2022
4107f11
Remove per-extension dependency install
code-asher Mar 29, 2022
ede7125
Include source maps
code-asher Mar 29, 2022
c24fa95
Refresh language patch
code-asher Mar 29, 2022
f228cc9
Add missing package.json
code-asher Mar 29, 2022
4ae5e26
Include keytar
code-asher Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing package.json 
This was caused by switching to Code's package step which does not
include the package.json.

Fixes #5019.
  • Loading branch information
@code-asher
code-asher committed Mar 29, 2022
commit f228cc9afe3c0184bad33462e1b63d2e86d8b59d
5 changes: 5 additions & 0 deletions ci/build/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ EOF

rsync "$VSCODE_SRC_PATH/remote/yarn.lock" "$VSCODE_OUT_PATH/yarn.lock"

# Include global extension dependencies as well.
rsync "$VSCODE_SRC_PATH/extensions/package.json" "$VSCODE_OUT_PATH/extensions/package.json"
rsync "$VSCODE_SRC_PATH/extensions/yarn.lock" "$VSCODE_OUT_PATH/extensions/yarn.lock"
rsync "$VSCODE_SRC_PATH/extensions/postinstall.js" "$VSCODE_OUT_PATH/extensions/postinstall.js"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👏🏼

pushd "$VSCODE_OUT_PATH"
symlink_asar
popd
Expand Down