Skip to content

feat: use the deployment's hostname suffix in the UI #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2025
Merged

feat: use the deployment's hostname suffix in the UI #133

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6462177
feat: use the deployment's hostname suffix in the UI
ethanndickson Apr 10, 2025
f141a74
fixup
ethanndickson Apr 10, 2025
5dea75f
fixup
ethanndickson Apr 10, 2025
e04f61a
thinking
ethanndickson Apr 11, 2025
cbd8ce4
move on start
ethanndickson Apr 11, 2025
a354ebe
review
ethanndickson Apr 14, 2025
75f17ca
fmt
ethanndickson Apr 14, 2025
ba2d732
fixup
ethanndickson Apr 14, 2025
26d2eb8
single cancelable refresh task
ethanndickson Apr 14, 2025
b6218fc
logs
ethanndickson Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@ethanndickson
ethanndickson committed Apr 10, 2025
commit 5dea75fdc1f238466667fa925832bf9228425448
7 changes: 5 additions & 2 deletions Coder-Desktop/Coder-Desktop/State.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class AppState: ObservableObject {
}
}

var client: Client?
private var client: Client?

@Published var useLiteralHeaders: Bool = UserDefaults.standard.bool(forKey: Keys.useLiteralHeaders) {
didSet {
Expand Down Expand Up @@ -118,7 +118,10 @@ class AppState: ObservableObject {
token: sessionToken!,
headers: useLiteralHeaders ? literalHeaders.map { $0.toSDKHeader() } : []
)
Task { await refreshDeploymentConfig() }
Task {
await handleTokenExpiry()
Copy link
Member Author

@ethanndickson ethanndickson Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by fix: we need to check for token expiry on app launch. We were previously only checking when the menu bar window was opened, and Connect was disabled. We need to account for when Connect is configured to start when the app is launched.

await refreshDeploymentConfig()
}
}
}

Expand Down
Loading