Skip to content

chore: add handler and router for coder scheme URIs #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented May 5, 2025

Relates to #96.
Closes #95

Copy link
Member Author

ethanndickson commented May 5, 2025

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is attached to the coder scheme.

@ethanndickson
Copy link
Member Author

ethanndickson commented May 5, 2025

I've run into the same issue described in #98, but with swift-collections when testing a release build of this PR stack. A development build works fine, but once the app is bundled with the dependency added in this PR, InternalCollectionsUtilities.framework is embedded into the app bundle but not the system extension bundle. This causes the system extension to panic on launch as it can't find the framework.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a handler and router to process coder scheme URIs while updating the project dependency configuration and deep link handling. Key changes include:

  • Adding the URLRouting package to the project configuration.
  • Implementing a new router in VPNLib to parse and match coder URLs.
  • Incorporating tests for various routing scenarios and updating deep link handling in the app delegate.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Coder-Desktop/project.yml Added URLRouting package dependency and updated targets.
Coder-Desktop/VPNLibTests/CoderRouterTests.swift Introduced comprehensive tests for the new router implementation.
Coder-Desktop/VPNLib/CoderRouter.swift Implemented the router and its associated types for coder URIs.
Coder-Desktop/Coder-Desktop/URLHandler.swift Added a URL handler to process matching coder URLs with error handling.
Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift Updated deep link handling by integrating the new URL handler.
Files not reviewed (3)
  • Coder-Desktop/Coder-Desktop/Info.plist: Language not supported
  • Makefile: Language not supported
  • scripts/build.sh: Language not supported

@ethanndickson ethanndickson requested a review from deansheather May 6, 2025 04:43
Copy link
Member Author

ethanndickson commented May 12, 2025

Merge activity

  • May 11, 10:46 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 11, 10:46 PM EDT: @ethanndickson merged this pull request with Graphite.

@ethanndickson ethanndickson merged commit 0cf2f28 into main May 12, 2025
4 checks passed
@ethanndickson ethanndickson deleted the ethan/uri-handler branch May 12, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coder URL scheme
2 participants