Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

feat(cli): AutoStart education notice [ch7441] #236

Merged
merged 4 commits into from
Feb 16, 2021
Merged

feat(cli): AutoStart education notice [ch7441] #236

merged 4 commits into from
Feb 16, 2021

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Feb 4, 2021 •
edited
Loading

I tried my best to get some cool info/ed information around AutoStart into the CLI ⚡

Demo

Env Pre-Run Cmds

I added this to:

  • envs create
  • envs rebuild

Env Create

$ go run ./cmd/coder/main.go envs create created-from-cli --image ubuntu --enable-autostart --org Coder
info: ⚡NEW: Automate daily environment startup
  | Visit https://master.cdr.dev/preferences?tab=autostart to configure your preferred time
warning: version mismatch detected
  | Coder CLI version: unknown
  | Coder API version: 1.14.0+743-g7c24d16bb-20210216
  | 
  | tip: download the appropriate version here: https://github.com/cdr/coder-cli/releases
success: creating environment...
  | 
  | tip: run "coder envs watch-build created-from-cli" to trail the build logs

Next Steps

Should we accept this effort, we should spawn a ticket to remove the education notice from the next non-patch release

@greyscaled greyscaled requested a review from cmoog February 4, 2021 20:54
@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #7441: CLI AutoStart Education.

greyscaled
greyscaled commented Feb 4, 2021
View reviewed changes
cmoog
cmoog suggested changes Feb 4, 2021
View reviewed changes
@greyscaled greyscaled requested a review from scsmithr February 16, 2021 20:27
@greyscaled greyscaled self-assigned this Feb 16, 2021
@greyscaled greyscaled requested a review from cmoog February 16, 2021 20:32
@greyscaled greyscaled changed the title feat(cli): AutoStart cmds, info [ch7441] feat(cli): AutoStart education notice [ch7441] Feb 16, 2021
scsmithr
scsmithr reviewed Feb 16, 2021
View reviewed changes
Copy link
Contributor

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not concerned about this being spammy. If we plan on removing this after some release, we should document that somewhere.

@scsmithr
Copy link
Contributor

I also see you have the "document somewhere" already figured out... didn't read Next Steps.

@greyscaled greyscaled enabled auto-merge (squash) February 16, 2021 20:44
@greyscaled greyscaled merged commit dd7b3a9 into master Feb 16, 2021
@greyscaled greyscaled deleted the vapurrmaid/ch7441 branch February 16, 2021 20:46
greyscaled added a commit that referenced this pull request Feb 19, 2021
@greyscaled
Revert "feat(cli): AutoStart education notice [ch7441] (#236)"
db3edcf 
This reverts commit dd7b3a9.

This commit should be re-reverted once the feature is
readied from the internal stage.
greyscaled added a commit that referenced this pull request Feb 19, 2021
@greyscaled
Revert "feat(cli): AutoStart education notice [ch7441] (#236)" (#249)
26b2794 
This reverts commit dd7b3a9.

This commit should be re-reverted once the feature is
readied from the internal stage.
greyscaled added a commit that referenced this pull request Mar 10, 2021
@greyscaled
Revert "Revert "feat(cli): AutoStart education notice [ch7441] (#236)" (
838f8d9 
#249)"

This reverts commit 26b2794.
greyscaled added a commit that referenced this pull request Mar 11, 2021
@greyscaled
Revert "Revert "feat(cli): AutoStart education notice [ch7441] (#236)" (
f33052b 
#249)" (#281)

This reverts commit 26b2794.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scsmithr scsmithr scsmithr left review comments

@cmoog cmoog cmoog approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greyscaled @scsmithr @cmoog