This repository was archived by the owner on Aug 30, 2024. It is now read-only.
feat: reuse http.Client #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jawnsy
commented
Feb 19, 2021
jawnsy
commented
- Create Client interface, so that it can be mocked/stubbed
- Validate client options at creation time
- Reuse internal HTTP Client, so that we have connection pooling
- Send the Session-Token in a header rather than cookie
* Create Client interface, so that it can be mocked/stubbed * Validate client options at creation time * Reuse internal HTTP Client, so that we have connection pooling * Send the Session-Token in a header rather than cookie
|
This pull request has been linked to Clubhouse Story #7910: Refactor coder-sdk to reuse http.Client. |
jawnsy
commented
Feb 22, 2021
cmoog
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
I could go either way on this one, so your call. One additional data point for consideration, take a look at how AWS does it with a separate package for the interface definitions https://github.com/aws/aws-sdk-go/blob/master/service/ec2/ec2iface/interface.go.
Not saying this is particularly clean, just another option.
jawnsy
changed the title
jawnsy
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.