Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

feat: add image:tag label to resources top #300

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Mar 23, 2021

The verbose output does seem to have gotten quite wide... probably worth considering adding a --label flag where the caller can opt-in to labels. I removed the alloc= resource prefixes since those don't exactly make sense until we have util metrics. I'm not too worried though given that this is hidden: True.

# on test cluster
coder resources top --group org --verbose
Coder    (53 members)    [cpu: 128.0vCPU]    [mem: 144.0GB]
    dev                [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]     [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]
    dev                [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]        [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]
    jawnsy-m           [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]    [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]
    kevinlint-coder    [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]       [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]
    my-dev-brazil      [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]       [img: coder-dogfood/master/enterprise-dev:latest]    [provider: brazil]
    grey-coder-us      [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]        [img: coder-dogfood/master/enterprise-dev:latest]    [provider: us]
    cvm                [cpu: 16.0vCPU]    [mem: 16.0GB]    [user: [email protected]]       [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]
    dev                [cpu: 16.0vCPU]    [mem: 32.0GB]    [user: [email protected]]       [img: coder-dogfood/master/enterprise-dev:latest]    [provider: built-in]

nathans-licensor-org    (1 member)    [cpu: 2.0vCPU]    [mem: 2.0GB]
    licensor    [cpu: 2.0vCPU]    [mem: 2.0GB]    [user: [email protected]]    [img: codercom/enterprise-dev:latest]    [provider: built-in]

greysorg    (4 members)    [cpu: 1.0vCPU]    [mem: 1.0GB]
    grey-test-pycharm    [cpu: 1.0vCPU]    [mem: 1.0GB]    [user: [email protected]]    [img: codercom/enterprise-pycharm:ubuntu]    [provider: built-in]

cc @jmcampanini

@cmoog cmoog requested a review from fuskovic March 23, 2021 15:49
@jmcampanini
Copy link
Contributor

nice! very much only nitpicking, and not at all something that should be considered blocking:

  • can make shorter by removing the vCPU unit on [cpu: ...]. unless there are plans to have different kinds of CPU types
  • img before user, since it's most likely that it's a uniform width than user (unsure how this may play out in practice, since i haven't used this a ton yet)

ty! :)

@cmoog cmoog merged commit 0bee6d1 into master Mar 23, 2021
@cmoog cmoog deleted the cmoog/resource-img-label branch March 23, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants