Add coder agent start #311
Conversation
| return fmt.Errorf("dial: %w", err) | ||
| } | ||
| nc := websocket.NetConn(context.Background(), conn, websocket.MessageBinary) | ||
| session, err := yamux.Server(nc, nil) |
There was a problem hiding this comment.
nitpicky since it doesn't really matter since yamux is bidirectional, but this should be a client because it's on the client end of a websocket connection
There was a problem hiding this comment.
@kylecarbs Any objections? (since this part is your code)
| if err != nil { | ||
| return fmt.Errorf("dial: %w", err) | ||
| } | ||
| nc := websocket.NetConn(context.Background(), conn, websocket.MessageBinary) |
There was a problem hiding this comment.
I know this is an MVP but there's a lot going on in this command so all of this should move into it's own package (or potentially even it's own repo if we want to use it within our monorepo as well).
There was a problem hiding this comment.
I pinky promise I'll do that if this ends up being a thing we stick with ;)
f0ssel
force-pushed
the
coder-agent-start
branch
from
8f6fd70 to
14fc0f8
Compare
f0ssel
force-pushed
the
coder-agent-start
branch
from
14fc0f8 to
8876078
Compare
|
this is incredible 🎉 |
| token string | ||
| ) | ||
| cmd := &cobra.Command{ | ||
| Use: "start [coderURL] --token=[token]", |
There was a problem hiding this comment.
do you think coderURL should be a --url flag? I'm imagining a case where this is defaulted to coder.com in the future for a SaaS offering. However, I know this isn't ideal for now since the coder agent start cmd would fail without the flags specified, so more so opening this up for discussion. Could potentially default coderURL to coder.com in the future as well if it's not specified as another option.
There was a problem hiding this comment.
Yeah this is suuuper mvp just to get a POC working in coder, a real implementation will follow once we get an idea of how scalable and stable this is.
|
I can't fix the |
Add a command to allow users to start the environment p2p agent. This command is hidden for now while we experiment.