Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

fix: Properly handle data channel timeout #328

Merged
merged 2 commits into from
Apr 30, 2021
Merged

fix: Properly handle data channel timeout #328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42f626f
fix: Properly handle data channel timeout
kylecarbs Apr 30, 2021
9b87bd3
Remove newline
kylecarbs Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: Properly handle data channel timeout
  • Loading branch information
@kylecarbs
kylecarbs committed Apr 30, 2021
commit 42f626fe977e0286134e4707a4a78da90dbfe03f
6 changes: 4 additions & 2 deletions xwebrtc/dialer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,12 @@ func (wc *WorkspaceDialer) peerConnection(ctx context.Context, workspaceID strin
}
go func() {
err = waitForDataChannelOpen(ctx, control)
_ = control.Close()
if err != nil {
wc.log.Fatal(ctx, "waiting for data channel open", slog.Error(err))

_ = conn.Close(websocket.StatusAbnormalClosure, "data channel timed out")
return
}
_ = control.Close()
_ = conn.Close(websocket.StatusNormalClosure, "rtc connected")
}()

Expand Down